@gadicc I know you're probably busy but just pinging you in case you missed this.

@huned thanks for the ping. Will do my best to review this in the coming days. Thanks for your patience! 🙏

Ok, @PythonCreator27, @huned; I realize this is going to hurt my popularity, especially after all the work you've both put in to this. But after a lot of thought on the matter, I've decided it's bad idea to create a historicalV8 module that tries to mimick historical but uses Yahoo's chart API under the hood. So, I've created a new _chart module (details should show up in the commit after this comment).

Upon doing so, I of course came across a lot of the issues you have both already addressed. In retrospect - and I do apologise - clearly simply asking you to rename the module and amend some of the docs would have been a better step, and I regret that I didn't realize this in the beginning.

In particular, I prefer the way @PythonCreator27 outputs the data (arrays with { date: ... } rather than Objects with timestamp keys). Originally I thought we could have a conversion module that relies on _chart, but ultimately realized the historicalV8 tries less harder than I thought to mimick the old historical's output and is just a lot more sensible than Yahoo's output.

So, let me put a little more thought into this... and again, I really do apologize at how I've handled this. Anyways, I'm going to push the changes now and we can have some discussion in a new issue which I'll link back to here too.

@huned, regarding also the failing test symbols, quoting chart.spec.ts:

  const symbolsToSkip = [
    "ADH", // currency: null; Yahoo-finance does show a chart though, should we allow this?
    "BEKE", // BadRequestError: Data doesn't exist for startDate = 1577836800, endDate = 1578009600
    "BFLY", // BadRequestError: Data doesn't exist for startDate = 1577836800, endDate = 1578009600
    "^VXAPL", // firstTradeDate: null; Yahoo-finance shows an empty chart even though there's some data.
  ];

Thanks also for the heads up on MDL, I removed all of these in 0daef32.

Thanks @gadicc ... And I think everything you're saying is eminently sensible (and no need to apologize for it).

I also had a weird gut feeling about calling it historical so I think _chart makes better sense. Will take a look at your commits and provide feedback on the output format tomorrow.

Thanks again 💯

Thanks, @huned!

And for your kind words. Nevertheless, I want my apology clearly on record for this one. I greatly value contributors' time and efforts on this project, which is a great help to me, and the community. I'm not in the habit of taking others' PR's and rewriting them as my own. In this case, it was only after finishing the code and then again looking back at this PR, that I really saw the similarity. On my next edit, I'll be adding a co-authored comment to the top of the file for the 3 of us.

Ok great, we'll chat about the rest in the other issue. Thanks again!